Flexible ETR buffer location #81387
Flexible ETR buffer location #81387
Conversation
Introduce etrbuffer in the tddconf bindings to support flexible placement in the memory map. Signed-off-by: Karsten Koenig <[email protected]>
karstenkoenig
requested review from
hubertmis and
nordic-krch
and removed request for
anangl
zephyrbot
requested review from
57300,
anangl,
jaz1-nordic,
jeremybettis,
kl-cruz,
magp-nordic,
masz-nordic,
nashif,
nika-nordic,
nordicjm and
tejlmand
karstenkoenig
force-pushed
the
tddconf_flexible_etrbuffer_upstream
branch
from
35c9815 to
5885efd
Compare
There was a problem hiding this comment.
Now that the buffer location is flexible, we should move it to cpuapp_ram0x_region instead of maintaining this disjoint region, re: #72273 (comment)
There was a problem hiding this comment.
I did that initially but that means that either cpurad_ram0x_region needs to move down by 4K or cpuapp_data in cpuapp_ram0x_region must be reduced by 4K and figured both aren't that great.
We are going to have a coalescing PR for memory regions anyway after dropping GenB support, maybe it could be done there?
There was a problem hiding this comment.
Not meaning to kick the ball just further to the next person, I can start having a look at the memory map given recent priority changes
There was a problem hiding this comment.
The snippet should shrink the cpuapp's SRAM in cpu_app_ram0x_region and place etr_buf_ram0x in there
karstenkoenig
force-pushed
the
tddconf_flexible_etrbuffer_upstream
branch
from
5885efd to
9d06a3a
Compare
|
Dropped moving the actual buffer from this PR, that also means this change can apply cleanly without a new sdsc bundle. We can move the memory region when new nrf-regtool and sdsc bundle are released |
|
@hubertmis @57300 can you please check again? I removed the memory section handling and will leave that for when nrf-regtool 8.1 and the associated sdfw is release that actually supports this. It's a bit of a circular dependency and this is the only way to break it up as far as I can tell. |
|
@anangl @masz-nordic Could you please have a look as well? I'd like to get that in so that the sdfw can start relying on the field and then improve the actual memory map |
What would you like me to check? I hope I'm not blocking this PR. I just answered one question. I'm OK to move the implementation of the required changes to another PR |
|
Sorry nah I think this is good enough, I just tried pushing it forward for the needed number of aprovers to get it merged. The etr memory overlay change will come when sdfw supports it, which is dependent on this here, so this needs to be first |
8 participants
Introduce etr-buffer into the tddconf binding to support flexible placement of the etr buffer in the memory map. The location will then be stored into the user information configuration registers and loaded on power on